minor updates for cartservice #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
🚲 PR staged at http://35.196.14.103 |
askmeegs
approved these changes
Jan 11, 2021
| wget -qO/bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \ | ||
| chmod +x /bin/grpc_health_probe | ||
| WORKDIR /app | ||
| COPY --from=builder /cartservice . | ||
| ENV ASPNETCORE_URLS http://*:7070 |
There was a problem hiding this comment.
just curious, what is the functionality of this? was cartservice using a .NET default, prior to this?
There was a problem hiding this comment.
Sure, this env var is one way to set the URL, especially when not using the default port: https://andrewlock.net/5-ways-to-set-the-urls-for-an-aspnetcore-app/. Before this PR, this env var was passed in the Kubernetes deployment file, now it's embedded in the Dockerfile instead. Hope that makes sense?
There was a problem hiding this comment.
Yes! That clarifies, thanks!
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* ASPNETCORE_URLS in Dockerfile * GRPC_HEALTH_PROBE_VERSION=v0.3.6 * Grpc.AspNetCore - 2.34.0 * more for dockerignore * typo * remove unused files * c# 9 syntax improvement with Program.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASPNETCORE_URLSenv inDockerfileProgram.csGrpc.AspNetCore- 2.34.0GRPC_HEALTH_PROBE_VERSION-v0.3.6.dockerignorefile