Turn off GCP integrations by default #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚲 PR staged at http://34.66.119.59 |
ahrarmonsur
approved these changes
Dec 20, 2021
askmeegs
changed the title
|
🚲 PR staged at http://34.66.119.59 |
|
🚲 PR staged at http://34.66.119.59 |
1 similar comment
|
🚲 PR staged at http://34.66.119.59 |
askmeegs
changed the title
NimJay
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
Thanks so much for doing this, @askmeegs!
Changes look good to me!
Ahrar has also done the appropriate testing.
Approved and merged.
Unrelated Note
I realized that the code style (e.g., bracket style) varies across this repository.
But again, this concern is definitely outside the scope of this pull-request.
Thus, I've created a separate GitHub issue about enforcing consistent coding style in JavaScript/Node.js service: #675.
| @@ -0,0 +1,25 @@ | |||
| # Integrating Online Boutique with Google Cloud | |||
There was a problem hiding this comment.
Praise: Thanks for documenting this, Megan!
This was referenced Feb 22, 2022
sitaramkm
added a commit
to sitaramkm/microservices-demo
that referenced
this pull request
Mar 27, 2022
* Turn off GCP integrations by default * Add doc * cleanup
copybaranaut
pushed a commit
to pixie-io/pixie
that referenced
this pull request
Jan 12, 2023
Summary: Fixes #689. The `px-online-boutique` demo app attempts to connect to GCP integrations. This causes problems when deployed on non-GCP clusters. This diff turns off GCP integrations by default for the demo app. This change has already been addressed upstream in GCP's repo, but at this time we do not want to update our fork of the repo. Upstream fix: GoogleCloudPlatform/microservices-demo#665 Test Plan: Manually deploy modified yaml file on GCP and EKS cluster. Reviewers: michelle Reviewed By: michelle Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D12773 GitOrigin-RevId: cc6645c78a19e33af4ee9bb70b4995ee1125850d
RagalahariP
pushed a commit
to RagalahariP/pixie
that referenced
this pull request
Feb 15, 2023
Summary: Fixes pixie-io#689. The `px-online-boutique` demo app attempts to connect to GCP integrations. This causes problems when deployed on non-GCP clusters. This diff turns off GCP integrations by default for the demo app. This change has already been addressed upstream in GCP's repo, but at this time we do not want to update our fork of the repo. Upstream fix: GoogleCloudPlatform/microservices-demo#665 Test Plan: Manually deploy modified yaml file on GCP and EKS cluster. Reviewers: michelle Reviewed By: michelle Signed-off-by: Hannah Troisi <htroisi@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D12773 GitOrigin-RevId: cc6645c78a19e33af4ee9bb70b4995ee1125850d
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* Turn off GCP integrations by default * Add doc * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Turns off Google Cloud Monitoring, Tracing, Profiler, and Debugger for all services by default, to re-enable out of the box support for local clusters.
Fixes
#663
Change Summary
DISABLE_PROFILER=1etc for all services, thus turning off GCP integrations by defaultTesting Procedure
PROJECT_IDenv field set (for GCR)skaffold run --default-repo=gcr.io/$PROJECT_ID/onlineboutiquethis will test thekubernetes-manifests, notrelease/on a local cluster. that's what you want.