Ignore .vs #86
Merged
Ignore .vs #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from Upstream
Merge from master
Merge from upstream
Merge from upstream
Merge from Upstream
googlebot
added
the
cla: yes
ahmetb
reviewed
Oct 23, 2018
.gitignore
Outdated
| @@ -5,6 +5,7 @@ pkg/ | |||
| *.swp | |||
| *~ | |||
| .vscode/ | |||
| .vs/ | |||
| .vs/slnx.sqlite | |||
There was a problem hiding this comment.
I think you can remove these 2 lines now?
also you might need to do git rm -rf .vs/
There was a problem hiding this comment.
My previous commit should have removed the only reference .vs in the codebase find . -name ".vs" returns nothing
|
@simonz130 are these OK to delete do you think? |
ahmetb
approved these changes
Oct 23, 2018
|
NP to remove what you already merged. |
|
Will do. I quickly double checked to see if .vs is ok to keep out of source control, seemed pretty straightforward. |
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83