Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/require env vars not empty #147

Merged

Conversation

acolver
Copy link
Collaborator

@acolver acolver commented May 1, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Thank you for raising the request! RAD Lab admins have been notified.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Apache 2.0 License check successful!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not update the README of the module here and once you commit, GitHub action should execute to do the same.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah looks like the README was updated via GitHub action itself.

Copy link
Collaborator

@guptamukul-google guptamukul-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not update the README of the module here and once you commit, GitHub action should execute to do the same.

Everything else looks good.

Copy link
Collaborator

@guptamukul-google guptamukul-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the README was updated via GitHub actions. we should be good to merge.

@acolver acolver merged commit 5cfae12 into GoogleCloudPlatform:staging May 4, 2023
@acolver acolver deleted the fix/require-env-vars-not-empty branch May 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants