Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No environment placeholder in configuration properties #491

Closed
ElectroLutz opened this issue Jun 7, 2021 · 3 comments · Fixed by #495
Closed

No environment placeholder in configuration properties #491

ElectroLutz opened this issue Jun 7, 2021 · 3 comments · Fixed by #495
Assignees
Labels

Comments

@ElectroLutz
Copy link

ElectroLutz commented Jun 7, 2021

Hey,

I guess that after #131 (edit: I guess it's since 2.0.2) it's not possible to have a configuration like the following anymore:

spring.cloud.gcp:
  sql:
    enabled: ${CLOUD_SQL_ENABLED:false}
    database-name: ${CLOUD_SQL_DATABASE:}
    instance-connection-name: ${CLOUD_SQL_INSTANCE:}
    credentials:
      encoded-key: ${CLOUD_SQL_KEY:}

The placeholders are not replaced anymore and the values are passed as they are in the application.yml.

How can I archive that they are replaced again? I don't want to use any config management, because until now the environment variables been doing their job.

Cheers
Marko

@elharo elharo added the type: question Further information is requested label Jun 7, 2021
@meltsufin
Copy link
Member

I think this is more likely caused by #273.
We disabled resolving placeholders to avoid issues with Secrets Manager placeholders resolver, but maybe we should just register a smarter resolver, or create an option to enable placeholder resolution.
cc/ @dzou.

meltsufin added a commit that referenced this issue Jun 8, 2021
Secret Manager placehoders are still skipped as before.

Fixes: #491.
meltsufin added a commit that referenced this issue Jun 8, 2021
Secret Manager placehoders are still skipped as before.

Fixes: #491.
meltsufin added a commit that referenced this issue Jun 8, 2021
Secret Manager placehoders are still skipped as before.

Fixes: #491.
@ElectroLutz
Copy link
Author

Thank you for the fast fix! Didn’t expect that.

@meltsufin
Copy link
Member

We like to pleasantly surprise sometimes. 😄

kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this issue Oct 20, 2022
Secret Manager placehoders are still skipped as before.

Fixes: GoogleCloudPlatform#491.
prash-mi pushed a commit that referenced this issue Jun 20, 2023
Bumps `slf4j.version` from 1.7.33 to 1.7.35.

Updates `slf4j-api` from 1.7.33 to 1.7.35
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.33...v_1.7.35)

Updates `slf4j-simple` from 1.7.33 to 1.7.35
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.33...v_1.7.35)

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.slf4j:slf4j-simple
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants