Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and remove unsed pom entries #1851

Merged
merged 1 commit into from
May 15, 2023
Merged

chore: cleanup and remove unsed pom entries #1851

merged 1 commit into from
May 15, 2023

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented May 15, 2023

This pr cleans up setups in pom for spring-cloud-gcp-data-firestore-sample related to native support (configured with outdated org.springframework.experimental:spring-native-configuration). It reverts what's added for the sample in #508.
The relevant native support module has stopped working for a while and was deleted in #1287. So it should be safe to also remove these setups in sample.

@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhumin8 zhumin8 marked this pull request as ready for review May 15, 2023 18:51
@zhumin8 zhumin8 requested review from JoeWang1127 and a team May 15, 2023 18:51
@zhumin8 zhumin8 merged commit 0def8c8 into main May 15, 2023
@zhumin8 zhumin8 deleted the fix-cleanup branch May 15, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants