Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

upgrade tgc #307

Merged
merged 3 commits into from
Sep 17, 2021
Merged

upgrade tgc #307

merged 3 commits into from
Sep 17, 2021

Conversation

ScottSuarez
Copy link
Contributor

fixes #268

upgrading tgc to consume the product url generation change created in GoogleCloudPlatform/magic-modules#5203

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one more failure left due to filestore -> file:

--- FAIL: TestReadPlannedAssetsCoverage (0.00s)
    --- FAIL: TestReadPlannedAssetsCoverage/example_filestore_instance (0.04s)
        read_test.go:103: 
            	Error Trace:	read_test.go:103
            	Error:      	Not equal: 
            	            	expected: []interface {}{map[string]interface {}{"ancestry_path":"organization/12345/folder/67890/project/ci-terraform-validator-fef2", "asset_type":"filestore.googleapis.com/Instance", "name":"//filestore.googleapis.com/projects/ci-terraform-validator-fef2/locations/us-central1-b/instances/test-instance", "resource":map[string]interface {}{"data":map[string]interface {}{"fileShares":[]interface {}{map[string]interface {}{"capacityGb":2660, "name":"share1"}}, "networks":[]interface {}{map[string]interface {}{"modes":[]interface {}{"MODE_IPV4"}, "network":"default"}}, "tier":"BASIC_SSD"}, "discovery_document_uri":"https://www.googleapis.com/discovery/v1/apis/file/v1/rest", "discovery_name":"Instance", "parent":"//cloudresourcemanager.googleapis.com/projects/ci-terraform-validator-fef2", "version":"v1"}}}
            	            	actual  : []interface {}{map[string]interface {}{"ancestry_path":"organization/12345/folder/67890/project/ci-terraform-validator-fef2", "asset_type":"file.googleapis.com/Instance", "name":"//file.googleapis.com/projects/ci-terraform-validator-fef2/locations/us-central1-b/instances/test-instance", "resource":map[string]interface {}{"data":map[string]interface {}{"fileShares":[]interface {}{map[string]interface {}{"capacityGb":2660, "name":"share1"}}, "networks":[]interface {}{map[string]interface {}{"modes":[]interface {}{"MODE_IPV4"}, "network":"default"}}, "tier":"BASIC_SSD"}, "discovery_document_uri":"https://www.googleapis.com/discovery/v1/apis/file/v1/rest", "discovery_name":"Instance", "parent":"//cloudresourcemanager.googleapis.com/projects/ci-terraform-validator-fef2", "version":"v1"}}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -3,4 +3,4 @@
            	            	   (string) (len=13) "ancestry_path": (string) (len=67) "organization/12345/folder/67890/project/ci-terraform-validator-fef2",
            	            	-  (string) (len=10) "asset_type": (string) (len=33) "filestore.googleapis.com/Instance",
            	            	-  (string) (len=4) "name": (string) (len=111) "//filestore.googleapis.com/projects/ci-terraform-validator-fef2/locations/us-central1-b/instances/test-instance",
            	            	+  (string) (len=10) "asset_type": (string) (len=28) "file.googleapis.com/Instance",
            	            	+  (string) (len=4) "name": (string) (len=106) "//file.googleapis.com/projects/ci-terraform-validator-fef2/locations/us-central1-b/instances/test-instance",
            	            	   (string) (len=8) "resource": (map[string]interface {}) (len=5) {
            	Test:       	TestReadPlannedAssetsCoverage/example_filestore_instance

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScottSuarez ScottSuarez merged commit 4335adc into main Sep 17, 2021
@ScottSuarez ScottSuarez deleted the update-tgc branch September 17, 2021 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KMS key ring & crypto key use incorrect domain in asset type and asset name
2 participants