Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude node headers #1597

Merged
merged 5 commits into from
May 21, 2024
Merged

Exclude node headers #1597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8aa0312
Exclude node headers
omBratteng May 16, 2024
c0f3943
Fix indentations
omBratteng May 16, 2024
4eb18dd
Fix order
omBratteng May 16, 2024
7711432
Another fix
omBratteng May 16, 2024
fdd0b48
Change it to only include license and binary
omBratteng May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nodejs/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@container_structure_test//:defs.bzl", "container_structure_test")

Check failure on line 1 in nodejs/BUILD

View workflow job for this annotation

GitHub Actions / Auto-format and Check 

Please run buildifier.
diff --git a/nodejs/BUILD b/nodejs/BUILD
index 2213b02..b596912 100644
--- a/nodejs/BUILD
+++ b/nodejs/BUILD
@@ -53,8 +53,8 @@ USER = [
         name = "nodejs" + major_version + ("" if (not mode) else mode) + "_" + user + "_" + arch + "_" + distro + "_test",
         configs = [
             "testdata/nodejs" + major_version + ".yaml",
+            "testdata/check_headers.yaml",
             "testdata/check_npm.yaml",
-			"testdata/check_headers.yaml"
         ],
         image = "nodejs" + major_version + ("" if (not mode) else mode) + "_" + user + "_" + arch + "_" + distro,
         tags = [
load("@rules_oci//oci:defs.bzl", "oci_image", "oci_image_index")
load("@rules_pkg//:pkg.bzl", "pkg_tar")
load("//:checksums.bzl", "ARCHITECTURES")
Expand Down Expand Up @@ -54,6 +54,7 @@
configs = [
"testdata/nodejs" + major_version + ".yaml",
"testdata/check_npm.yaml",
"testdata/check_headers.yaml"
],
image = "nodejs" + major_version + ("" if (not mode) else mode) + "_" + user + "_" + arch + "_" + distro,
tags = [
Expand Down
5 changes: 5 additions & 0 deletions nodejs/testdata/check_headers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
schemaVersion: "2.0.0"
fileExistenceTests:
- name: npm
path: '/nodejs/include/node/node.h'
shouldExist: false
3 changes: 3 additions & 0 deletions private/remote/node_archive.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ pkg_tar(
"output/bin/corepack",
"output/bin/npm",
"output/bin/npx",
"output/CHANGELOG.md",
"output/README.md",
"output/include/**",
],
),
package_dir = "/nodejs",
Expand Down
Loading