Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Proposal: Build to Docker Daemon #243

Closed
coollog opened this issue May 1, 2018 · 4 comments
Closed

Implement Proposal: Build to Docker Daemon #243

coollog opened this issue May 1, 2018 · 4 comments
Assignees
Labels

Comments

@coollog
Copy link
Contributor

coollog commented May 1, 2018

Addresses proposal #223

Fixes #48

@TadCordle
Copy link
Contributor

TadCordle commented May 3, 2018

So here's my plan for this, not necessarily in this order. I'm hoping each of these checkboxes can be a separate PR.

@coollog Let me know if you think this is good approach, or if there's any important info I could be missing (still pretty unfamiliar with a lot of this).

@coollog
Copy link
Contributor Author

coollog commented May 3, 2018

@TadCordle looks good!

@loosebazooka
Copy link
Member

I think it might be good practice to avoid exposing as a task/goal until it is ready. You can either build from core up to maven/gradle. Or start with skeletons in maven/gradle but don't expose them (don't do a project.tasks.create or @Mojo). In some cases, probably not ours since we're targeting our next release, exposing the incomplete task/goal makes it harder to do releases while this feature is being developed.

@TadCordle
Copy link
Contributor

Oh true, I already pushed the empty tasks, should I hide them in the next PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants