Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach build to docker daemon functionality to maven goal #266

Merged
merged 2 commits into from
May 10, 2018
Merged

Attach build to docker daemon functionality to maven goal #266

merged 2 commits into from
May 10, 2018

Conversation

TadCordle
Copy link
Contributor

Fixes #243.

Still a couple refactoring TODOs, see #262.

@TadCordle TadCordle mentioned this pull request May 10, 2018
Closed
@coollog
Copy link
Contributor

coollog commented May 10, 2018

Should also update the CHANGELOG in some followup PR

@TadCordle TadCordle merged commit e0fcb5d into master May 10, 2018
@TadCordle TadCordle deleted the docker_daemon_goal branch May 10, 2018 20:32
@TadCordle TadCordle mentioned this pull request May 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coollog coollog coollog approved these changes

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

Assignees
No one assigned
Labels
area/jib-maven-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TadCordle @coollog