Changes the builder steps to use the new ncache.Cache. #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
chanseokoh
reviewed
Sep 27, 2018
...src/integration-test/java/com/google/cloud/tools/jib/registry/BlobPullerIntegrationTest.java
Show resolved
Hide resolved
...e/src/main/java/com/google/cloud/tools/jib/builder/steps/PushContainerConfigurationStep.java
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildConfiguration.java
Show resolved
Hide resolved
| try (InputStreamReader stderr = | ||
| new InputStreamReader(dockerProcess.getErrorStream(), StandardCharsets.UTF_8)) { | ||
| throw new IOException( | ||
| "'docker load' command failed with error: " + CharStreams.toString(stderr)); |
There was a problem hiding this comment.
Are you fixing #1013? Perhaps do this in another PR?
There was a problem hiding this comment.
Ah right, I added this to debug something. I'll remove this from this PR.
| Image<Layer> testImage = | ||
| Image.builder() | ||
| .addLayer( | ||
| new Layer() { |
There was a problem hiding this comment.
If you prefer using a mock, you could do .addLayer(mockLayer) and when(mockLayer.getBlob()).thenReturn(Blobs.from(fileA)).
There was a problem hiding this comment.
I'll change to that to make the code less boiler-platey.
chanseokoh
reviewed
Sep 27, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/BuildImageStep.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #637
ncache.Cache.cachepackage. (Had to get rid of it in this one since some of the changes caused compilation errors in the oldcachepackage)ncachetocache.