-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorg and refactor repo - continued #1684
Merged
Merged
Changes from 34 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
0688f28
Decouple Blob
chanseokoh ec340f3
Rename ImageToTarTranslator
chanseokoh 305f254
Rename test class
chanseokoh 02b42ad
Decouple Blob from TarStreamBuilder
chanseokoh 0ff040a
empty commit to stalled Kokoro
chanseokoh ac3ef64
Clean up
chanseokoh 447573d
more intuitive code
chanseokoh 8098dc3
wip
chanseokoh 181dbad
wip
chanseokoh ca070aa
Merge branch 'master' into cleanup-3
chanseokoh efd85ef
Revert TarStreamBuilder
chanseokoh 21067f7
wip
chanseokoh 96a047e
Merge branch 'master' into cleanup-3
chanseokoh ec4a67f
Remove Blob dep from DigestUtil
chanseokoh 2cf3c4b
Move WritableContents to hash package
chanseokoh e5bb5e9
More refactoring
chanseokoh 8b82327
Decouple Blob from http Response
chanseokoh 873ada8
wip
chanseokoh a647b80
Decouple Blob from http Request
chanseokoh 8f96337
test
chanseokoh d3bfc7a
Reorg and refactor
chanseokoh c047f8c
Merge branch 'master' into cleanup-2
chanseokoh 11d7b60
wip
chanseokoh 52c6455
done
chanseokoh f293268
Fix wrong filename
chanseokoh e4461b4
Remove more Blob indirection
chanseokoh c7aee9e
Merge branch 'cleanup-2' into cleanup-4
chanseokoh 40f6666
Rename
chanseokoh d6f02da
Rename
chanseokoh 6eccb7e
Merge branch 'master' into cleanup-4
chanseokoh ea31cfc
private
chanseokoh f27ff67
Refactor
chanseokoh f2be62e
Clean up
chanseokoh e75f8e0
Fix Javadocs
chanseokoh 523b4f7
Update Javadocs
chanseokoh a746d54
Merge remote-tracking branch 'origin/master' into cleanup-4
chanseokoh c74330c
Rename
chanseokoh e2b3434
Merge branch 'master' into cleanup-4
chanseokoh b8640af
Push up throttling decision
chanseokoh 3fba22b
Rename "with..." to "from..."
chanseokoh 6f9ea9b
Specialize ThrottledConsumer
chanseokoh 70d0747
Fix Javadoc
chanseokoh 998d56a
ListenableCountingOutputStream -> NotifyingOutputStream
chanseokoh 70be4b2
optionalOutStream -> outStream
chanseokoh d6842e6
ThrottledLongConsumer -> ThrottledAccumulatingConsumer
chanseokoh c5fedc7
ThrottledLongConsumer -> ThrottledAccumulatingConsumer
chanseokoh 60778ee
Merge branch 'master' into cleanup-4
chanseokoh 421a032
Merge branch 'cleanup-4' of https://github.com/GoogleContainerTools/j…
chanseokoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit weird to have to call the constructor and this method to fully initialize a
ProgressEventDispatcherWrapper
, maybe we can consolidate this by changing the signature ofRegistryClient#pullBlob
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did not like this wrapper either. The problem Q originally faced was the progress reporting design that
Content-Length
.dispatchProgress()
.For this reason, obviously it's best to get rid of this unfortunate wrapper if possible. As an attempt to work around the issue, Q probably also felt it doesn't make much sense to have this wrapper in the signature and make it a hard dependency from the API standpoint, also given that there are only just a couple places this wrapper is required. And as I said in the earlier comment, my intention is to actually decouple progress dispatcher stuff from
RegistryClient
.