Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated extraDirectory config #2108

Merged
merged 4 commits into from
Nov 18, 2019
Merged

Remove deprecated extraDirectory config #2108

merged 4 commits into from
Nov 18, 2019

Conversation

TadCordle
Copy link
Contributor

@TadCordle TadCordle commented Oct 29, 2019 •
edited by chanseokoh
Loading

Fixes #1691 #2160.

@TadCordle TadCordle added the PR: Merge After Release This PR should only be merged after the release stated in description. label Oct 29, 2019
@TadCordle TadCordle mentioned this pull request Oct 29, 2019
Merged
@TadCordle TadCordle removed the PR: Merge After Release This PR should only be merged after the release stated in description. label Nov 15, 2019
@TadCordle TadCordle requested a review from a team November 18, 2019 16:03
chanseokoh
chanseokoh approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests pass locally, right?

@TadCordle
Copy link
Contributor Author

I'll run them again to be sure.

@TadCordle TadCordle merged commit 8361d92 into master Nov 18, 2019
@TadCordle TadCordle deleted the i1691-remove-extraDirectory branch November 18, 2019 16:35
This was referenced Nov 19, 2019
Closed
Merged
zhumin8 pushed a commit that referenced this pull request Jul 14, 2022
@KENNYSOFT
Fix documentation of configuring extraDirectories for Gradle plugin (#…
e505a95 
…3682)

jib.extraDirectories = file('build/extra-directory') is one of the older syntax shown here, that is later deprecated in #1671 and removed in #2108.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated extraDirectory and associated configs
3 participants
@TadCordle @chanseokoh @googlebot