Update Build Plan API to accept file ownership in layers #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
commented
May 26, 2020
| @@ -121,12 +158,13 @@ public boolean equals(Object other) { | |||
| FileEntry otherFileEntry = (FileEntry) other; | |||
| return sourceFile.equals(otherFileEntry.sourceFile) | |||
| && extractionPath.equals(otherFileEntry.extractionPath) | |||
| && Objects.equals(permissions, otherFileEntry.permissions) | |||
| && Objects.equals(modificationTime, otherFileEntry.modificationTime); | |||
There was a problem hiding this comment.
Perhaps Objects.equals was necessary in the past when permissions and modificationTime were @Nullable. The java.util.Objects.equals is implemented like the following, so we don't need it.
public static boolean equals(Object a, Object b) {
return (a == b) || (a != null && a.equals(b));
}
loosebazooka
approved these changes
May 26, 2020
| @@ -265,6 +326,10 @@ public FileEntriesLayer build() { | |||
| DEFAULT_MODIFICATION_TIME_PROVIDER = | |||
| (sourcePath, destinationPath) -> DEFAULT_MODIFICATION_TIME; | |||
|
|
|||
| /** Provider that returns default file ownership ("0:0"). */ | |||
There was a problem hiding this comment.
the comment and the return value don't really line up?
There was a problem hiding this comment.
Fixed. Also updated the Build Plan Spec doc with the last commit.
|
Merging this now to start releasing early. |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards writing an extension for #1257 and #1955, as well as a workaround for #1270.
Once merged, we need to re-publish all the libraries one after another.