-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FAQ for Jib CLI #3118
Update FAQ for Jib CLI #3118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3118 +/- ##
============================================
- Coverage 71.12% 71.08% -0.04%
- Complexity 2315 2320 +5
============================================
Files 278 280 +2
Lines 9790 9825 +35
Branches 991 992 +1
============================================
+ Hits 6963 6984 +21
- Misses 2482 2495 +13
- Partials 345 346 +1 Continue to review full report at Codecov.
|
When changing titles, don't forget to update the ToC and link refs. |
Yup, I totally agree with these thoughts. Specifying the limitation of the current support for fat JARs will offer a lot of clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one minor comment.
And please test the new ToC links after merging. (I made a mistake with the Jib config FAQ before, if you remember 😄)
Thanks for the heads up! Verified the links to make sure they were okay:) |
No description provided.