Add creation date to container config to avoid Docker saying image is 292 years old #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
approved these changes
Jun 18, 2018
| * and avoid Docker's weird "292 years old" bug. | ||
| * | ||
| * @see <a | ||
| * href="https://github.com/GoogleContainerTools/jib/issues/341">https://github.com/GoogleContainerTools/jib/issues/341</a> |
There was a problem hiding this comment.
I think it's worth exploring some of the options mentioned in the bazel build bugs also : https://groups.google.com/forum/#!topic/istio-dev/nuv6UaBFGDk (like allowing a user configurable time)? or an env variable. Perhaps file a followup bug for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it says 48 years old, but it's better than 292 years (and now it matches distroless).
Fixes #341.