Does not authenticate pull unless the image requires authentication. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadCordle
reviewed
Jun 19, 2018
|
|
||
| Authorization registryCredentials = | ||
| NonBlockingSteps.get(retrieveBaseRegistryCredentialsStep); | ||
| return new Result(pullBaseImage(registryCredentials), registryCredentials); |
There was a problem hiding this comment.
Maybe pullBaseImage could just return a Result instead of having to wrap the returned image in a new one.
There was a problem hiding this comment.
Usually I think that'd be good, though here it would mean just calling the new Result in the returns in pullBaseImage, but pullBaseImage is intended to be a method that just pulls the base image using the credentials, whereas Result is the result of the step as a whole. I'll add a javadoc for this method.
| @@ -21,6 +21,8 @@ | |||
| import com.google.cloud.tools.jib.async.NonBlockingSteps; | |||
| import com.google.cloud.tools.jib.blob.Blobs; | |||
| import com.google.cloud.tools.jib.builder.BuildConfiguration; | |||
| import com.google.cloud.tools.jib.builder.steps.PullBaseImageStep.Result; | |||
There was a problem hiding this comment.
Is this import necessary?
There was a problem hiding this comment.
Yea, it is actually necessary for the class to use Result as the template.
|
|
||
| private static final String DESCRIPTION = "Pulling base image manifest"; | ||
|
|
||
| /** Structure for the result returned by this step. */ | ||
| static class Result { |
There was a problem hiding this comment.
maybe a more descriptive name?
TadCordle
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376
This improves build speed by ~500ms for default distroless base image.