Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passes allowHttp to RegistryAuthenticator. #572

Merged
merged 3 commits into from
Jul 12, 2018
Merged

Passes allowHttp to RegistryAuthenticator. #572

merged 3 commits into from
Jul 12, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Jul 12, 2018

Should be able to fix #545

Also fixes #558

Essentially, the problem was that the allowHttp configuration was not being passed down to the RegistryClient used to get the RegistryAuthenticator.

@coollog coollog added this to the v0.9.6 milestone Jul 12, 2018
@coollog coollog requested a review from a team July 12, 2018 03:20
@coollog coollog merged commit 732abe2 into master Jul 12, 2018
@coollog coollog deleted the allow-http-registryauthenticator branch July 12, 2018 03:39
@davidecavestro davidecavestro mentioned this pull request Jul 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
priority :p0
Projects
None yet
Milestone
v0.9.6
Development

Successfully merging this pull request may close these issues.

Remove unused RegistryAuthenticators.forDockerHub()? maven settings credential did not work
2 participants
@coollog @chanseokoh