Skips execution if packaging is 'pom'. #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2018
TadCordle
approved these changes
Jul 30, 2018
|
I mean this is an easy way to fix the problem, but maven is configurable to avoid this. Actually never mind, this makes everyone's life easier. |
|
Should we only be executing on "jar" builds, and ignoring all other builds? or does that mess up error messaging? |
|
@loosebazooka We could, though we would want to enable "war" too when we take care of #431. However, we might want to allow for custom packaging types, though I'm not if people actually do that. |
|
Yeah, I'm not sure if I know what the right way is. Perhaps just leave it as is for now, maybe implementing a "jib" packaging type option can clear this up for most people. |
loosebazooka
approved these changes
Jul 30, 2018
|
Oops, forgot to add CHANGELOG. Will do in followup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734
The code duplication will be taken care of by when we add a plugins-common framework (#478).