Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container.appRoot config parameter #984
Add container.appRoot config parameter #984
Changes from 22 commits
520222a
971b95d
5b16ded
5a7f486
5024da9
ee6fe2c
d568f6e
886d71d
d86d749
85c6132
4ef4148
a1ba423
12face5
93b42a7
35a64f6
c16531d
a978e4c
6330547
0e8c597
6489596
713c673
6dd49a9
984f51c
c70f5a3
3b7c510
21bec72
4d5154d
becad9c
e699be8
99c7d1d
2d74e9d
28ac010
566561f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking more about this enum where we need to dynamically decide the final extraction path, I'm now leaning toward getting rid of static extraction path initialization with the
appRootRelative
switch. Instead, theJavaLayerConfiguration.Builder()
could accept the extraction path when setting layer files. That is, changesetClassFiles(List<Path> classFiles)
tosetClassFiles(String extractionPath, List<Path> classFiles)
. That seems more straightforward for our dynamic path requirement and simpler. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea that sounds good. One nit is to have it be
setClassFiles(List<Path> classFiles, String extractionPath)
to be more likeLayerEntry
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should name these both
layerConfigurationsMap
so this can be the more familiarthis.x = x
form?