Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor container-diff call #1077

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

greut
Copy link
Contributor

@greut greut commented Feb 26, 2020

Description

This refactors the integration_test.go part that deal with container-diff to avoid repetitions and mistakes.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

no use facing changes.

Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 26, 2020
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@tejal29 tejal29 merged commit 7aa737c into GoogleContainerTools:master Feb 28, 2020
@greut greut deleted the container-diff branch February 28, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants