Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set very large logs to Trace level #1203

Merged
merged 1 commit into from
May 1, 2020

Conversation

dani29
Copy link
Contributor

@dani29 dani29 commented Apr 18, 2020

Description
When tried to work on an issue with --verbosity=debug, these logs made it really difficult. When slices contain >10k items, the produced log is very hard to traverse. Therefore, I suggest moving them to trace level in case they are needed, but otherwise this change will make --verbosity=debug a little more pleasant to work with.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Apr 18, 2020
@tejal29 tejal29 merged commit 36748fa into GoogleContainerTools:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants