Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1227 - Readded the /kaniko/.docker directory #1230

Merged
merged 3 commits into from
May 6, 2020
Merged

Fixes #1227 - Readded the /kaniko/.docker directory #1230

merged 3 commits into from
May 6, 2020

Conversation

D3N14L
Copy link
Contributor

@D3N14L D3N14L commented May 5, 2020

Fixes #1227.

Description

This directory was implicitly removed with commit
8a02001 and breaks several peoples
builds as some examples and documentation expect the directory to exist.

Submitter Checklist

  • Includes unit tests
  • Adds integration tests if needed.

Added empty directory. No additional unit or integration tests required.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Readded the /kaniko/.docker directory to not break existing build pipelines.

This directory was implicitly removed with commit
8a02001 and breaks several peoples
builds as some examples and documentation expect the directory to exist.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label May 5, 2020
@D3N14L
Copy link
Contributor Author

D3N14L commented May 5, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels May 5, 2020
@D3N14L
Copy link
Contributor Author

D3N14L commented May 5, 2020

Failing due to "429 too many requests" errors when downloading dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing '.docker' folder in release 0.20.0 break backward compatibility in some pipelines
3 participants