Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix COPY with --chown command #1477

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

sladyn98
Copy link
Contributor

@sladyn98 sladyn98 commented Nov 3, 2020

Fixes 1456

Description

According to this #1456 (comment) I just checked if userStrand groupStr are already int before calling out to GetUserFromUsername.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Nov 3, 2020
@tejal29
Copy link
Member

tejal29 commented Nov 4, 2020

thanks for the PR. @sladyn98 can you fix the lint failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COPY with --chown command should not require user or group IDs to exist
2 participants