Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(warmer): Warmer now supports all registry-related flags #1499

Merged
merged 1 commit into from
Dec 11, 2020
Merged

feat(warmer): Warmer now supports all registry-related flags #1499

merged 1 commit into from
Dec 11, 2020

Conversation

vbehar
Copy link
Contributor

@vbehar vbehar commented Nov 20, 2020 •
edited
Loading

Fixes #1423

Description

This PR adds all registry-related flags to the warmer command

which means we can now:

  • set up one or more mirrors
  • set up registries certificates
  • skip TLS verify
  • use plain HTTP
    using the same set of flags that are defined for the executor command

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

warmer now supports the following flags:
- `--insecure-pull`
- `--skip-tls-verify-pull`
- `--insecure-registry`
- `--skip-tls-verify-registry`
- `--registry-certificate`
- `--registry-mirror`

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Nov 20, 2020
@tejal29
Copy link
Member

tejal29 commented Dec 9, 2020

@vbehar Would be able to rebase this PR on master?

@vbehar
Copy link
Contributor Author

vbehar commented Dec 9, 2020

sure, I'll do it today

@vbehar
feat(warmer): Warmer now supports all registry-related flags
ac2c71c 
which means we can now:
- set up one or more mirrors
- set up registries certificates
- skip TLS verify
- use plain HTTP
using the same set of flags that are defined for the executor
@vbehar vbehar marked this pull request as ready for review December 9, 2020 09:24
@vbehar
Copy link
Contributor Author

vbehar commented Dec 9, 2020

@tejal29 ok, rebased and ready

tejal29
tejal29 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vbehar for all the refactoring. the code org certainly looks better.

@tejal29 tejal29 merged commit dde98a8 into GoogleContainerTools:master Dec 11, 2020
@finkr finkr mentioned this pull request Aug 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Registry mirror for warmer.
2 participants
@vbehar @tejal29