Add DEVELOPMENT.md #238
Merged
Add DEVELOPMENT.md #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
approved these changes
Jul 18, 2018
DEVELOPMENT.md
Outdated
|
|
||
| #### Integration tests | ||
|
|
||
| The integration tests live in [`integration`](./integration) and can be run with: |
There was a problem hiding this comment.
Our integration tests require having access to the kaniko-test project to run locally, so instead let's say that maintainers of the project are responsible for running integration tests on PRs before approving them
There was a problem hiding this comment.
Ah kk sounds good!
README.md
Outdated
| * Standard Kubernetes cluster | ||
| * Kubernetes Secret | ||
|
|
||
| - Standard Kubernetes cluster (e.g. using [GKE](https://cloud.google.com/kubernetes-engine/) or [Minikube](https://kubernetes.io/docs/setup/minikube/)) |
There was a problem hiding this comment.
I'm not sure if kaniko works with Minikube actually, maybe we remove this for now?
This commit adds docs aimed at folks interested in ramping up and contributing to kaniko. It starts with setting up a github account and forking to make sure the barrier to entry is as low as possible.
bobcatfish
force-pushed
the
developer_docs
branch
from
6e795fd
to
ac3d364
Compare
|
Ready for another look @priyawadhwa ! |
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds docs aimed at folks interested in ramping up and
contributing to kaniko.
It starts with setting up a github account and forking to make sure the
barrier to entry is as low as possible.