Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cut everything after an equals sign #381

Merged

Conversation

blacksails
Copy link
Contributor

I tried to provide a build build arg like this: --build-arg ARG_WITH_EQUALS="This has an = char" which results in $ARG_WITH_EQUALS having a value of This has an

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@container-tools-bot
Copy link
Collaborator

Hi @blacksails. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@blacksails
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@blacksails blacksails changed the title dont cut everything after and equals sign Don't cut everything after an equals sign Oct 3, 2018
@blacksails
Copy link
Contributor Author

Just fyi i pushed an image with the fix to lixtech/kaniko, and i seems to work as intended.

Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@priyawadhwa priyawadhwa merged commit 919df39 into GoogleContainerTools:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants