Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support specifying branch for cloning #703

Merged
merged 5 commits into from
Jul 16, 2019
Merged

feat: support specifying branch for cloning #703

merged 5 commits into from
Jul 16, 2019

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Jun 22, 2019

this allows to specify a reference to clone in the same way npm allows: appending #reference to the URL, eg: git://github.com/GoogleContainerTools#refs/tags/v0.10.0

I'm not sure this is a good approach, but was the one I could think of without needing to change much.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@bryanhuntesl
Copy link

@caarlos0 - could you push a no-op commit to get the checks completed - they're blocking on "kokoro Expected — Waiting for status to be reported "

@bryanhuntesl
Copy link

@caarlos0 - and, sorry to bother you again - do you think it's possible to get the checksum argument into the URL?

I'd be willing to try implementing if you/they were interested (erlang dev here - but I'll try).

I've been trying to get some feedback on https://groups.google.com/forum/#!topic/kaniko-users/G4TieNB8YaM

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0
Copy link
Contributor Author

caarlos0 commented Jul 14, 2019

@caarlos0 - and, sorry to bother you again - do you think it's possible to get the checksum argument into the URL?

AFAIK no, only branches and tags :/

Would need to do a full clone and then git checkout the given reference for it to work...

@caarlos0
Copy link
Contributor Author

@caarlos0 - could you push a no-op commit to get the checks completed - they're blocking on "kokoro Expected — Waiting for status to be reported "

yeah seems like it refuses to run for some reason

@caarlos0
Copy link
Contributor Author

cc/ @priyawadhwa

Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@priyawadhwa priyawadhwa merged commit 32b3b4f into GoogleContainerTools:master Jul 16, 2019
@bryanhuntesl
Copy link

Thanks @priyawadhwa !

@caarlos0 caarlos0 deleted the git-branch branch July 17, 2019 19:40
@caarlos0
Copy link
Contributor Author

thanks!

@caarlos0 caarlos0 restored the git-branch branch October 22, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants