Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pull request template #795

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Add a pull request template #795

merged 1 commit into from
Sep 27, 2019

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Sep 27, 2019

Mention

  1. Unit tests
  2. Release notes block

tequilarista
tequilarista reviewed Sep 27, 2019
View reviewed changes
Copy link

@tequilarista tequilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple - love it!

One niggly: "The code flow looks good" is probably to vague to be helpful. Is there anyway we can be more convcrete here?

@donmccasland donmccasland merged commit 09bf862 into master Sep 27, 2019
@cvgw cvgw deleted the tejal29-pr-template branch December 9, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tequilarista tequilarista tequilarista left review comments

@donmccasland donmccasland donmccasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejal29 @donmccasland @tequilarista