Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaniko version #796

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Kaniko version #796

merged 4 commits into from
Oct 4, 2019

Conversation

prary
Copy link
Contributor

@prary prary commented Oct 2, 2019

#772

Description
Enabling kaniko versioning

Submitter Checklist

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

@tejal29
Copy link
Member

tejal29 commented Oct 2, 2019

@prary Can you please run the gofmt on your branch ?

find . -name "*.go" | grep -v vendor/ | xargs gofmt -l -s -w

Once you are done, you can verify the file lints are fixed
by

  1. Running make test
  2. ./hack/linter.sh

@tejal29 tejal29 merged commit 1c821d0 into GoogleContainerTools:master Oct 4, 2019
@tejal29 tejal29 self-requested a review October 4, 2019 21:32
@tejal29
Copy link
Member

tejal29 commented Oct 4, 2019

Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants