828: clean up docker doc, fix context var in run cmd #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@priyawadhwa - Issue that came up while working on #812. Let me know if this needs any changes. |
priyawadhwa
reviewed
Oct 22, 2019
There was a problem hiding this comment.
@codevbus thanks for your contribution! Left a couple comments, please let me know if you have any questions.
|
@priyawadhwa - made changes based on your feedback. |
priyawadhwa
reviewed
Oct 24, 2019
| @@ -35,9 +35,9 @@ if [[ ! -e $HOME/.config/gcloud/application_default_credentials.json ]]; then | |||
| fi | |||
|
|
|||
| docker run \ | |||
| -v $HOME/.config/gcloud:/root/.config/gcloud \ | |||
| -v ${context}:/workspace \ | |||
| -v "$HOME"/.config/gcloud:/root/.config/gcloud \ | |||
There was a problem hiding this comment.
Are the changes to this file necessary?
There was a problem hiding this comment.
Most likely not, although it's generally safer to use "" in this case. Let me know if you want me to revert @priyawadhwa
There was a problem hiding this comment.
That's alright, let's keep this! Thanks.
priyawadhwa
approved these changes
Oct 28, 2019
|
LGTM thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828. in case of a bug fix, this should point to a bug and any other related issue(s)
Description
${context}var interpolation to run command.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.