Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci.yaml file matching current config #893

Merged

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Nov 28, 2019

Description

Add golangci.yaml file matching current config to make it easier to retain the same linting configuration when upgrading version of golangci-lint. Also serves as a more easily accessible source of documentation for our linting config.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

@cvgw cvgw force-pushed the u/cvgw/golangci-lint-configfile branch from 9e14acb to 6734a97 Compare November 28, 2019 18:08
@tejal29 tejal29 merged commit db8f8ad into GoogleContainerTools:master Dec 9, 2019
@cvgw cvgw deleted the u/cvgw/golangci-lint-configfile branch December 9, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants