Fix #940 set modtime when extracting

[cvgw]

Fixes #940
Description

Certain utilities like Apt depend on modtime for certain files. Kaniko was not setting modtime when extracting files and so this broke things like apt.

Kaniko now sets the file mod time to the value from the tar header.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes unit tests
• Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- Set Modification Time when extracting files so things like apt work properly

[cvgw]

This should also fix #793

[vguaglione]

@cvgw Has this fix been added to the latest executor and debug executor images? Just tried it (pulling both from gcr.io/kaniko-project via docker pull) and still see the issue.

[cvgw]

@vguaglione yes it has been added to those images. If you are still seeing this issue can we move the conversation back to the issue? #793

[vguaglione]

@vguaglione yes it has been added to those images. If you are still seeing this issue can we move the conversation back to the issue? #793

We are. Yes, can we reopen 793 @cvgw?

Also curious about latest kaniko debug image... We have started experiencing build issues today using the latest debug version of the executor. This was not happening on our builds yesterday. Nothing has changed on our end. Partial sample output below. I can go ahead and open a separate issue for this one but wanted to give you a heads up:

INFO[0000] Unpacking rootfs as cmd RUN apk update && apk upgrade --available requires it.
error building image: error building stage: failed to get filesystem from image: error removing var/run to make way for new symlink: unlinkat /var/run/secrets/kubernetes.io/serviceaccount/..2020_02_04_20_51_10.295485154: read-only file system
ERROR: Job failed: command terminated with exit code 1

[cvgw]

We are. Yes, can we reopen 793 @cvgw?

Yes we can. Would you mind adding a new comment with your repro steps or just mention that they are the same steps from before. I'll repro and then reopen the issue

Also curious about latest kaniko debug image... We have started experiencing build issues today using the latest debug version of the executor. This was not happening on our builds yesterday. Nothing has changed on our end. Partial sample output below. I can go ahead and open a separate issue for this one but wanted to give you a heads up:

cc @tejal29 about status of tag debug

[vguaglione]

We are. Yes, can we reopen 793 @cvgw?

Yes we can. Would you mind adding a new comment with your repro steps or just mention that they are the same steps from before. I'll repro and then reopen the issue

Also curious about latest kaniko debug image... We have started experiencing build issues today using the latest debug version of the executor. This was not happening on our builds yesterday. Nothing has changed on our end. Partial sample output below. I can go ahead and open a separate issue for this one but wanted to give you a heads up:

cc @tejal29 about status of tag debug

Updated #793 with information detailing error in the executor:debug version of the container. Please review.