Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run helm show chart for version range #685

Merged

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Jun 15, 2023

  • reverts add retries around helm templating step #674 (as it was just experimental and didn't end up helping at all)
  • changes it so that we only run helm show chart if the version is provided to us as a range (using the same range processing library that helm uses). If it's not provided as a range, we skip the expensive polling.
  • bumps the cpu req for the version range test

b/286870867

@natasha41575 natasha41575 changed the title only run helm show chart for version range only run helm show chart for version range Jun 15, 2023
@natasha41575
Copy link
Contributor Author

/assign @haiyanmeng

pkg/helm/helm.go Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label Jun 15, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haiyanmeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1466724 into GoogleContainerTools:main Jun 15, 2023
6 checks passed
@natasha41575 natasha41575 deleted the fixhelmtests branch June 15, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants