Profile support for dockerEnv() extension #146
Conversation
minikube-gradle-plugin/src/main/java/com/google/cloud/tools/minikube/MinikubeExtension.java
Outdated
Show resolved
Hide resolved
minikube-gradle-plugin/src/main/java/com/google/cloud/tools/minikube/MinikubeExtension.java
Outdated
Show resolved
Hide resolved
minikube-gradle-plugin/src/main/java/com/google/cloud/tools/minikube/MinikubeExtension.java
Outdated
Show resolved
Hide resolved
minikube-gradle-plugin/src/test/java/com/google/cloud/tools/minikube/MinikubeExtensionTest.java
Outdated
Show resolved
Hide resolved
minikube-gradle-plugin/src/test/java/com/google/cloud/tools/minikube/MinikubeExtensionTest.java
Outdated
Show resolved
Hide resolved
minikube-gradle-plugin/src/test/java/com/google/cloud/tools/minikube/MinikubeExtensionTest.java
Outdated
Show resolved
Hide resolved
minikube-gradle-plugin/src/test/java/com/google/cloud/tools/minikube/MinikubeExtensionTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for the useful remarks! Addressed. |
There was a problem hiding this comment.
Just a few minor things.
Can you also update either the bug #141 or this PR to include a reference to the minikube docs for profile?
|
@loosebazooka, I could not find any documentation on this. Here's the issue for the documentation request: kubernetes/minikube#2371 Could just link to that issue. |
|
@gintautassulskus I'm a little curious about what the exact behavior is, I'll try talking to the minikube team and see if I can get a followup on that issue. |
|
If you have a particular question, let me know. I may be able to answer it as well. Our development workflow relies on profile feature but unfortunately not all the tools support it. So far |
minikube-gradle-plugin/src/test/java/com/google/cloud/tools/minikube/MinikubeExtensionTest.java
Outdated
Show resolved
Hide resolved
…for null replaced wildcard improt with explicit imports
There was a problem hiding this comment.
Hey @gintautassulskus this looks good, one minor fix and we can probably merge this in. Thanks again for contributing.
minikube-gradle-plugin/src/test/java/com/google/cloud/tools/minikube/MinikubeExtensionTest.java
Outdated
Show resolved
Hide resolved
#141
Added profile support for dockerEnv() extension
dockerEnv(), dockerEnv("") - refer to default minikube profile
dockerEnv(profile) - refer to custom minikube profile