Prefix Composer Dependencies #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Infrastructure
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
swissspidy
force-pushed
the
add/amp-wp
branch
from
e56381f
to
b502c90
Compare
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
3 times, most recently
from
60bc23b
to
6e78b55
Compare
This comment has been minimized.
This comment has been minimized.
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
from
6e78b55
to
d7b3057
Compare
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
5 times, most recently
from
539b27a
to
9c31977
Compare
swissspidy
force-pushed
the
add/amp-wp
branch
2 times, most recently
from
1f5f761
to
cdb6b26
Compare
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
from
9c31977
to
99896bd
Compare
swissspidy
force-pushed
the
add/amp-wp
branch
from
cdb6b26
to
da5c804
Compare
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
from
99896bd
to
b3db291
Compare
swissspidy
changed the title
|
@westonruter @schlessera @spacedmonkey I feel like this is now ready for initial review, so I'd love to get your feedback. Please note that this PR is based on #4513 and solves the conflict resolving part of that PR. @felixarntz FYI I added you as a reviewer in case you have some feedback for us on this based on prior art in Site Kit. The Site Kit implementation was certainly a good inspiration, although I went for an easier route heree. |
felixarntz
reviewed
Sep 24, 2020
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
5 times, most recently
from
fa851d0
to
fb1b47d
Compare
Codecov Report
@@ Coverage Diff @@
## add/amp-wp #4543 +/- ##
==============================================
- Coverage 75.12% 75.04% -0.09%
==============================================
Files 888 894 +6
Lines 15518 15782 +264
==============================================
+ Hits 11658 11843 +185
- Misses 3860 3939 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
3 times, most recently
from
ce6e207
to
85fef9e
Compare
swissspidy
added
Type: Enhancement
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
from
e0194db
to
cb8c302
Compare
westonruter
approved these changes
Oct 2, 2020
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
from
cb8c302
to
ad2a148
Compare
swissspidy
force-pushed
the
add/amp-wp-scoping
branch
from
ad2a148
to
05ce6e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prefixes dependencies to avoid conflicts with the AMP plugin and other plugins using these dependencies.
Relevant Technical Choices
civicrm/composer-downloads-pluginto work around PHP version mismatch issuesthird-partyandincludesmakes building the plugin ZIP file much fastercomposer validateCI step as it doesn't work withmcaskill/composer-exclude-filesTo-do
ClassLoadercompatibility issuesSee PSR-0/4 dependencies are not correctly prefixed humbug/php-scoper#355, PSR-4 loader conflict with older implementation composer/composer#3852, https://github.com/dangoodman/composer-for-wordpress, https://gist.github.com/polevaultweb/de44d747b57191a851947d5f5175e922
User-facing changes
N/A
Testing Instructions
composer installor check out this branch on the QA siteAddresses one aspect of #4513