Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable using system keyring for accesstoken/PAT with azuredevops #1000

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Enable using system keyring for accesstoken/PAT with azuredevops #1000

merged 3 commits into from
Aug 30, 2023

Conversation

bratne
Copy link
Contributor

@bratne bratne commented Aug 10, 2023

Wanted to store the secret using bugwarrior vault list / set. Didn't work with azure dev ops. Fixed in this PR

ryneeverett
ryneeverett approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@ryneeverett ryneeverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the typo and flake8's formatting complaints (causing the CI failure).

bugwarrior/services/azuredevops.py Outdated Show resolved Hide resolved
@bratne
Copy link
Contributor Author

bratne commented Aug 11, 2023

typo and flake8 compatibility fixed

@ryneeverett ryneeverett merged commit 7cd4612 into GothenburgBitFactory:develop Aug 30, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryneeverett ryneeverett ryneeverett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bratne @ryneeverett