Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accidental death of character #593

Closed
MapleNe opened this issue May 6, 2022 · 10 comments
Closed

Accidental death of character #593

MapleNe opened this issue May 6, 2022 · 10 comments
Labels
bug Something isn't working todo Something to complete

Comments

@MapleNe
Copy link

MapleNe commented May 6, 2022 •
edited
Loading

When I fall down and attack many times and talk to NPC, the character will die
or fall down attack one time
当我多次下落攻击之后和NPC对话角色就会死亡
pls watch video
请看视频
video
https://imgur.com/a/2gRrXw9
@lunaticwhat
Copy link
Member

provided video links doesn't work

@MapleNe
Copy link
Author

MapleNe commented May 6, 2022

provided video links doesn't work

on discord channel #support-zh

@lunaticwhat
Copy link
Member

provided video links doesn't work

on discord channel #support-zh

can you mention me @lunatic#1911 ?

@MapleNe
Copy link
Author

MapleNe commented May 6, 2022

provided video links doesn't work

on discord channel #support-zh

can you mention me @lunatic#1911 ?

okay

@lunaticwhat
Copy link
Member

I see. Might be a bug with character taken damage handler and may related to pr #551

@lunaticwhat lunaticwhat added bug Something isn't working todo Something to complete labels May 6, 2022
@gentlespoon
Copy link
Contributor

Could be related to #551. I'll have a look at this.

@gentlespoon
Copy link
Contributor

Can confirm is caused by #551. But wth does talking to NPC send a MotionState.MOTION_FALL_ON_GROUND packet?

gentlespoon added a commit to gentlespoon/Grasscutter that referenced this issue May 6, 2022
@gentlespoon
Fix Grasscutters#593: Accidental death of character
f0fab84
@gentlespoon
Copy link
Contributor

@Melledy

ghost pushed a commit that referenced this issue May 6, 2022
@gentlespoon
Fix #593: Accidental death of character
c582814
@gentlespoon
Copy link
Contributor

@MapleNe Try again.

@lunaticwhat
Copy link
Member

fixed with PR #601. Closed to clean up the workspace.

Birdulon pushed a commit to Birdulon/Grasscutter that referenced this issue Aug 21, 2022
@gentlespoon
Fix Grasscutters#593: Accidental death of character
58cb602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working todo Something to complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gentlespoon @MapleNe @lunaticwhat