Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend give command "skill level" & shortening /talent all #1865

Merged
merged 15 commits into from
Oct 18, 2022
Merged

Extend give command "skill level" & shortening /talent all #1865

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0b253cf
Extend give command "talent"
natsurepo Oct 16, 2022
be0148e
Merge remote-tracking branch 'origin/development' into development
natsurepo Oct 16, 2022
83c70b3
Update src/main/java/emu/grasscutter/data/excels/AvatarSkillDepotData…
natsurepo Oct 16, 2022
735f090
Fix setSkillLevel to work during avatar construction
natsurepo Oct 17, 2022
58943f0
Merge remote-tracking branch 'origin/development' into development
natsurepo Oct 17, 2022
24f0d79
changeSkillLevel now acts as intermediate operation to fetch skillIds
natsurepo Oct 17, 2022
9a91ca5
Merge branch 'development' into development
natsurepo Oct 17, 2022
04d9486
setSkillLevel changes to allow out of range levels to be normalized
natsurepo Oct 17, 2022
2faee0b
Update src/main/java/emu/grasscutter/command/commands/GiveCommand.java
natsurepo Oct 17, 2022
497847d
Major changes and cleanup:
natsurepo Oct 17, 2022
bbd71cb
Merge remote-tracking branch 'origin/development' into development
natsurepo Oct 17, 2022
3d49a6d
Merge branch 'Grasscutters:development' into development
natsurepo Oct 17, 2022
da2a692
Small cleanup:
natsurepo Oct 17, 2022
2c1e6fb
Merge remote-tracking branch 'origin/development' into development
natsurepo Oct 18, 2022
ea55f48
Small cleanup:
natsurepo Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changeSkillLevel now acts as intermediate operation to fetch skillIds
  • Loading branch information
@natsurepo
natsurepo committed Oct 17, 2022
commit 24f0d795c0e6e746acbd10c66704f27cf96541d1
13 changes: 6 additions & 7 deletions src/main/java/emu/grasscutter/game/avatar/Avatar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,18 +774,17 @@ public boolean setSkillLevel(int skillId, int level) {
this.save();

// Packet
this.getPlayer().sendPacket(new PacketAvatarSkillChangeNotify(this, skillId, oldLevel, level));
this.getPlayer().sendPacket(new PacketAvatarSkillUpgradeRsp(this, skillId, oldLevel, level));
val player = this.getPlayer();
if (player != null) {
player.sendPacket(new PacketAvatarSkillChangeNotify(this, skillId, oldLevel, level));
player.sendPacket(new PacketAvatarSkillUpgradeRsp(this, skillId, oldLevel, level));
}
return true;
}

public void changeSkillLevel(int skillLevel) {
natsurepo marked this conversation as resolved.
Show resolved Hide resolved
if (skillLevel < 1) skillLevel = 1;
if (skillLevel > 12) skillLevel = 12; // Set max to 12 at the moment instead of 15 (it will conflict with constellation's talent level bonus)
int finalSkillLevel = skillLevel;
skillDepot.getCombatSkills().forEach(id -> this.skillLevelMap.put(id, finalSkillLevel));
this.save();
this.recalcStats(true);
skillDepot.getCombatSkills().forEach(id -> this.setSkillLevel(id, skillLevel));
}

public boolean unlockConstellation() {
Expand Down