Handle Dungeons with null config #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingRainbow44
approved these changes
Jul 31, 2023
Comment on lines
+56
to
+62
| if(dungeonData.getPassCond() == 0){ | ||
| this.passConfigData = new DungeonPassConfigData(); | ||
| this.passConfigData.setConds(new ArrayList<>()); | ||
| }else { | ||
| this.passConfigData = GameData.getDungeonPassConfigDataMap().get(dungeonData.getPassCond()); | ||
| } | ||
| this.finishedConditions = new int[this.passConfigData.getConds().size()]; |
There was a problem hiding this comment.
i pray the formatter changes these
| @@ -76,6 +81,7 @@ public void triggerEvent(DungeonPassConditionType conditionType, int... params) | |||
| } | |||
|
|
|||
| public boolean isFinishedSuccessfully() { | |||
| if(passConfigData.getLogicType()==null) return false; | |||
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In DungeonExcelConfigData.json, some dungeons have passCond and some do not. passCond are for referencing DungeonPassExcelConfigData.json where there are things such as finish conditions.
Grasscutter null pointer exception'd when a dungeon didn't have passCond.
Issues fixed by this PR
Backstabber water dude's dungeon and battle works!
Type of changes
Checklist: