-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed can set talent level to 16 bug #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Level should be **lower than 16**
haven't it corrected already? the way you add the = just make the character talent getting locked |
Talent level should be 15 or lower due to client-side restrictions |
The problem now is that the talent level can be set to 16, my commit fixed that. |
memetrollsXD
approved these changes
May 1, 2022
What happens clientside for a level of 0, or negative numbers? |
It also locks the talents I’d imagine
|
oops, sorry. Talent lv15 only available in event |
Which characters? Max is 15..
|
Birdulon
pushed a commit
to Birdulon/Grasscutter
that referenced
this pull request
Aug 21, 2022
Level should be **lower than 16**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level should be lower than 16