Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed can set talent level to 16 bug #408

Merged
merged 1 commit into from
May 1, 2022
Merged

Fixed can set talent level to 16 bug #408

merged 1 commit into from
May 1, 2022

Conversation

jie65535
Copy link
Contributor

@jie65535 jie65535 commented May 1, 2022

Level should be lower than 16

Level should be **lower than 16**
@alt3ri
Copy link
Member

alt3ri commented May 1, 2022

haven't it corrected already? the way you add the = just make the character talent getting locked

@memetrollsXD
Copy link
Member

Talent level should be 15 or lower due to client-side restrictions

@jie65535
Copy link
Contributor Author

jie65535 commented May 1, 2022

The problem now is that the talent level can be set to 16, my commit fixed that.
Please review again

@memetrollsXD memetrollsXD reopened this May 1, 2022
@memetrollsXD memetrollsXD merged commit ec09bc2 into Grasscutters:development May 1, 2022
@Birdulon
Copy link
Member

Birdulon commented May 1, 2022

What happens clientside for a level of 0, or negative numbers?

@memetrollsXD
Copy link
Member

memetrollsXD commented May 1, 2022 via email

@jie65535 jie65535 deleted the patch-2 branch May 1, 2022 14:46
@alt3ri
Copy link
Member

alt3ri commented May 1, 2022

oops, sorry. Talent lv15 only available in event

@memetrollsXD
Copy link
Member

memetrollsXD commented May 1, 2022 via email

@jie65535
Copy link
Contributor Author

jie65535 commented May 1, 2022

Set talent level to 15

Set talent level to 15

Set talent level to 16

Set talent level to 16

Birdulon pushed a commit to Birdulon/Grasscutter that referenced this pull request Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants