Added a "help" player command and "sendmsg" server command. Separated commands and aliases #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added player "Help" command, added server "sendmsg" command, changed getAcccountByPlayerID to public in DatabaseHelper, and allowed player commands to be submitted with "/" and "!"
|
segg |
ghost
merged commit 
4Benj
added a commit
to Grasscutter-Backrooms/Grasscutter
that referenced
this pull request
Jul 12, 2022
## Description Please carefully read the [Contributing note](https://github.com/Grasscutters/Grasscutter/blob/stable/CONTRIBUTING.md) and [Code of conduct](https://github.com/Grasscutters/Grasscutter/blob/development/CODE_OF_CONDUCT.md) before making any pull requests. And, **Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.** ## Issues fixed by this PR <!--- Put the links of issues that may be fixed by this PR here (if any). --> ## Type of changes <!--- Put an `x` in all the boxes that apply your changes. --> - [ ] Bug fix - [x] New feature - [x] Enhancement - [ ] Documentation ## Checklist: - [x] My code follows the style guidelines of this project - [x] My pull request is unique and no other pull requests have been opened for these changes - [x] I have read the [Contributing note](https://github.com/Grasscutters/Grasscutter/blob/stable/CONTRIBUTING.md) and [Code of conduct](https://github.com/Grasscutters/Grasscutter/blob/development/CODE_OF_CONDUCT.md) - [x] I am responsible for any copyright issues with my code if it occurs in the future. Co-authored-by: ayy lmao <ridvan-nuri@windowslive.com> Co-authored-by: Benj <benjamin7006@gmail.com> Reviewed-on: https://git.4benj.com/Grasscutter-Backrooms/Grasscutter/pulls/9
4Benj
added a commit
to Grasscutter-Backrooms/Grasscutter
that referenced
this pull request
Jul 12, 2022
## Description Please carefully read the [Contributing note](https://github.com/Grasscutters/Grasscutter/blob/stable/CONTRIBUTING.md) and [Code of conduct](https://github.com/Grasscutters/Grasscutter/blob/development/CODE_OF_CONDUCT.md) before making any pull requests. And, **Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.** ## Issues fixed by this PR <!--- Put the links of issues that may be fixed by this PR here (if any). --> ## Type of changes <!--- Put an `x` in all the boxes that apply your changes. --> - [ ] Bug fix - [x] New feature - [x] Enhancement - [ ] Documentation ## Checklist: - [x] My code follows the style guidelines of this project - [x] My pull request is unique and no other pull requests have been opened for these changes - [x] I have read the [Contributing note](https://github.com/Grasscutters/Grasscutter/blob/stable/CONTRIBUTING.md) and [Code of conduct](https://github.com/Grasscutters/Grasscutter/blob/development/CODE_OF_CONDUCT.md) - [x] I am responsible for any copyright issues with my code if it occurs in the future. Co-authored-by: ayy lmao <ridvan-nuri@windowslive.com> Co-authored-by: Benj <benjamin7006@gmail.com> Reviewed-on: https://git.4benj.com/Grasscutter-Backrooms/Grasscutter/pulls/9
Birdulon
pushed a commit
that referenced
this pull request
Aug 21, 2022
Added a "help" player command and "sendmsg" server command. Separated commands and aliases
yunochan
pushed a commit
to yunochan/Grasscutter
that referenced
this pull request
Jul 4, 2024
Troubleshooting in README.md
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
help me pls (Might be an issue later with the auto-scroll within genshin's chat)
Sends a message to the player
sendmsg [player id] [message]
I did this because the helpText for existing commands seemed to assume that the commands used '/'.
This was for sendmsg. I don't know why getAccountById would be public and getAccountByPlayerId isn't. If there was a better way to do this, I'll happily change sendmsg to use that and revert my change.