Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for automation workflows #11

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Hotfix for automation workflows #11

merged 2 commits into from
Oct 18, 2024

Conversation

iamwatchdogs
Copy link
Contributor

fixed the permission and proper events, this events changes might led to security concerns. But for as of now, this might resolve the issue of workflow not working properly for the PRs made from forked repos.

@iamwatchdogs
Updated workflows
8c1cf5f 
fixed the permission and proper events, this events changes might
led to security concerns. But for as of now, this might resolve
the issue of workflow not working properly for the PRs made from
forked repos.
@iamwatchdogs iamwatchdogs self-assigned this Oct 18, 2024
@iamwatchdogs
Updated the events for workflows
73bae23 
Removed pull_request event which might be triggering the workflow
instead of pull_request_target. This could fix this issue but might
raise some security concerns.
@iamwatchdogs
Copy link
Contributor Author

Removed pull_request event which might be one triggering the workflow instead of pull_request_target, thus failing the workflows. I realised this after checking the workflow written within the repo of auto-commenter's action which was used for with one of our recently added workflows.

@iamwatchdogs iamwatchdogs added bug Something isn't working hacktoberfest Opted for hacktoberfest labels Oct 18, 2024
iamwatchdogs
iamwatchdogs commented Oct 18, 2024
View reviewed changes
Copy link
Contributor Author

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by @iamwatchdogs.

@iamwatchdogs iamwatchdogs merged commit ebca0f6 into Grow-with-Open-Source:main Oct 18, 2024
@iamwatchdogs iamwatchdogs deleted the hotfix branch October 18, 2024 11:42
@github-actions GitHub Actions
Copy link

Thank you for contributing @iamwatchdogs. Make sure to check your contribution on GitHub Pages.

@github-actions github-actions bot added the hacktoberfest-accepted Successfully accepted pull request for hacktoberfest label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iamwatchdogs iamwatchdogs

Labels
bug Something isn't working hacktoberfest Opted for hacktoberfest hacktoberfest-accepted Successfully accepted pull request for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamwatchdogs