Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new (v00-15) podio generated class names #26

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

vvolkl
Copy link
Member

@vvolkl vvolkl commented Feb 2, 2022

- Replace some dedicated types with  and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205.
@SanghyunKo
Copy link
Collaborator

Hi @vvolkl, thanks for the commit. CI does not work obviously but I checked that it works with the lastest Podio + EDM4hep + k4FWCore, and with HEP-FCC/k4SimGeant4#15. This will break support for lcg releases but I think we can get it back once we have AIDASoft/podio#238.

@SanghyunKo SanghyunKo merged commit b96e258 into HEP-FCC:master Feb 3, 2022
@vvolkl
Copy link
Member Author

vvolkl commented Feb 3, 2022

Hi Sanghyun, thanks for merging this so quickly. Besides explicitly checking for versions, I think it could also be possible to keep compatibilty with earlier versions just by deducing the type of thePtr from m_Edeps. but it would be less straightforward. Since it's the only change that is needed for the podio class renaming, it may be worthwhile though, I'll take another look.

@vvolkl vvolkl deleted the podio-mutable branch February 3, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants