Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Login: Fails with status 500 if user does not have Display Name #22

Closed
DonMartin76 opened this issue Oct 19, 2016 · 0 comments
Closed

GitHub Login: Fails with status 500 if user does not have Display Name #22

DonMartin76 opened this issue Oct 19, 2016 · 0 comments
Labels
bug
Milestone
0.10.0

Comments

@DonMartin76
Copy link
Member

If a user does not have a Display Name in GitHub, login/signup fails with status 500, "Failed to fetch user profile".
DonMartin76 added a commit to apim-haufe-io/wicked.api that referenced this issue Oct 19, 2016
@DonMartin76
Partial fix of Haufe-Lexware/wicked.haufe.io#22
41072a7 
- Display Name in portal looks bad if user only has partial display name in GitHub.
DonMartin76 added a commit to apim-haufe-io/wicked.ui that referenced this issue Oct 19, 2016
@DonMartin76
Fix for Haufe-Lexware/wicked.haufe.io#22
4b35d08 
- If a Github user does not have a displayName, the username is picked instead
- If the username (for whatever reason) is not available, the fixed string 'Unknown' is picked.
DonMartin76 added a commit to apim-haufe-io/wicked.ui that referenced this issue Oct 19, 2016
@DonMartin76
Fix number two for Haufe-Lexware/wicked.haufe.io#22
b5b3a56 
If you realize you have a null object, you should not try to access it anyway.
@DonMartin76 DonMartin76 added this to the 0.10.0 milestone Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@DonMartin76