Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kickstarter: removing the last chat webhook breaks the editor. #73

Closed
ehirsch opened this issue Jun 20, 2017 · 1 comment
Closed

Kickstarter: removing the last chat webhook breaks the editor. #73

ehirsch opened this issue Jun 20, 2017 · 1 comment
Labels
bug priority: low
Milestone
0.11.7

Comments

@ehirsch
Copy link

ehirsch commented Jun 20, 2017

This is a rather small issue.

When remove the last (and only) chatbot webhook url and when I save the config. I will be greeted with an error page:

TypeError: /usr/src/app/views/chatbot.jade:37
    35|                                     button(type='submit' onclick='setAction("addHook");').btn.btn-sm.btn-success Add Hook URL
    36|                     .panel-body
  > 37|                         each hookUrl, i in glob.chatbot.hookUrls
    38|                             - var thisHookName = 'glob.chatbot.hookUrls['+i+']'
    39|                             +inputField(thisHookName, glob, 'Hook URL', 'See documentation of Slack or Rocket.Chat how to get one of these.')
    40|                             p 

Cannot read property 'length' of undefined

Wicked version is 0.11.6
DonMartin76 added a commit to apim-haufe-io/wicked.kickstarter that referenced this issue Jul 18, 2017
@DonMartin76
Fixes Haufe-Lexware/wicked.haufe.io#73 - add guard for non-existing c…
3e7e504 
…hatbot hooks
DonMartin76 added a commit to apim-haufe-io/wicked.chatbot that referenced this issue Jul 18, 2017
@DonMartin76
Additional fix for Haufe-Lexware/wicked.haufe.io#73 - don't crash if …
39c690e 
…chatbot hook URL list is not present.
@DonMartin76 DonMartin76 added this to the 0.11.7 milestone Jul 18, 2017
@DonMartin76
Copy link
Member

Fixed in 0.11.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority: low
Projects
None yet
Milestone
0.11.7
Development

No branches or pull requests
2 participants
@ehirsch @DonMartin76