Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: the host property of the swagger.json is not properly overwritten #99

Closed
DonMartin76 opened this issue Jan 13, 2018 · 1 comment
Closed

Regression: the host property of the swagger.json is not properly overwritten #99

DonMartin76 opened this issue Jan 13, 2018 · 1 comment
Labels
bug
Milestone
0.12.4

Comments

@DonMartin76
Copy link
Member

The host property is no longer properly overridden to reflect the host of the API gateway; it takes what's in the swagger.json, which may or may not be correct (usually it isn't).
DonMartin76 added a commit to apim-haufe-io/wicked.api that referenced this issue Jan 13, 2018
@DonMartin76
Fixes regression bug Haufe-Lexware/wicked.haufe.io#99
7f351f0 
With the implementation of the href referencing, the overwriting of host, basePath and schemes was lost. Dammit.
DonMartin76 added a commit to apim-haufe-io/wicked.test that referenced this issue Jan 13, 2018
@DonMartin76
Add a test for Haufe-Lexware/wicked.haufe.io#99 - check host, basePat…
a9b3239 
…h and schemes on Swagger.
@DonMartin76 DonMartin76 added this to the 0.12.4 milestone Jan 13, 2018
@DonMartin76
Copy link
Member Author

Fixed in 0.12.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.12.4
Development

No branches or pull requests
1 participant
@DonMartin76