Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Only Fade if Extended #3748

Open
wants to merge 15 commits into
base: thewarwithin
Choose a base branch
from

Conversation

Garretonzo
Copy link

@Garretonzo Garretonzo commented Sep 12, 2024

Problem:
I like to mash whatever button is shown, but I want to follow the recommendations perfectly. This includes ability delays.
When using the Extend Spiral option under the Delays tab, it is hard to tell when an ability is being delayed by some additional amount of time vs the regular gcd.
Currently, when enabling the Fade as Unusable option, the ability will fade even if there was no extra delay added.
I thought combining these options would be very helpful.

Solution:
This adds a feature to improve the clarity of when an ability's delay is extended.
New behavior - If "Only Fade if Extended" is enabled (requires both Extend Spiral and Fade as Unusable options to be enabled), it will only fade if the ability was extended beyond the regular duration.

Please review, would love to see this feature make it into the addon.

@Garretonzo Garretonzo changed the title DRAFT: Only fading the icon if both "extend" and "fade" are checked, if the ability was extended Improve clarity of Fade as Unusable when Extend Spiral is enabled Sep 12, 2024
@Garretonzo
Copy link
Author

Garretonzo commented Sep 12, 2024

Added an explicit option to only fade the ability when both Fade and Extend are checked, if the ability delay was extended.

This maintains previous functionality while providing an option to enable this logic.

@Garretonzo Garretonzo changed the title Improve clarity of Fade as Unusable when Extend Spiral is enabled Feature: Only Fade if Extended Sep 12, 2024
@Gyudon47
Copy link

Wow! This is actually what I'm looking for!

@Hekili
Copy link
Owner

Hekili commented Sep 13, 2024

It looks like you updated it to make it function per-display rather than globally, so I don't have to follow-up and ask for that.

I'll toy with this later and see about including it.

@Garretonzo
Copy link
Author

Cool! Please do let me know if you'd like to see something about it changed, I had fun figuring this much out.
I love this addon and would be very proud to be a contributor, albeit through a very small, niche addition.

@johnnylam88
Copy link
Contributor

Is Extended a good description of what's happening? Maybe Wait instead, as in wait past GCD?

@Garretonzo
Copy link
Author

Garretonzo commented Sep 15, 2024

I'm impartial to the semantics
So I'd name it whatever the heck
That said, I worded things after the already existing options "Fade as Unusable" and "Extend Spiral"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants