Skip to content

Commit

Permalink
Add repackaged jetty to our list of maven exports
Browse files Browse the repository at this point in the history
  • Loading branch information
shs96c committed Aug 25, 2016
1 parent 487af37 commit dd3f2e8
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 15 deletions.
1 change: 1 addition & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ JAVA_RELEASE_TARGETS = [
'//java/client/src/org/openqa/selenium:client-combined',
'//java/server/src/com/thoughtworks/selenium:leg-rc',
'//java/server/src/org/openqa/grid/selenium:classes',
'//third_party/java/jetty:jetty'
]


Expand Down
46 changes: 32 additions & 14 deletions third_party/java/jetty/BUCK
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
java_library(
name = 'jetty',
maven_coords = 'org.seleniumhq.selenium:jetty-repacked:9.2.13.v20150730',
maven_coords = 'org.seleniumhq.selenium:jetty-repacked:9.2.13.v20160825',
maven_pom_template = 'jetty.pom',
exported_deps = [
':jetty-http-repacked',
':jetty-security-repacked',
':jetty-server-repacked',
':jetty-servlet-repacked',
':jetty-servlets-repacked',
':jetty-util-repacked',
':repackage',
],
deps = [
':jetty-continuation-repacked',
':jetty-io-repacked',
':jetty-jmx-repacked',
'//third_party/java/servlet:servlet-api',
],
visibility = [
'//java/client/test/com/thoughtworks/selenium:tests',
Expand All @@ -27,7 +21,29 @@ java_library(
'//java/server/test/org/openqa/selenium/remote/server/auth:lib',
],
)


# We want the deployable 'jetty-repacked' artifact to not require each of the
# individual jars (we did, after all, repackage everything). By introducing a
# prebuilt_jar we avoid that problem.
prebuilt_jar(name = 'repackage',
binary_jar = ':bundle-jars',
)

java_binary(
name = 'bundle-jars',
deps = [
':jetty-http-repacked',
':jetty-security-repacked',
':jetty-server-repacked',
':jetty-servlet-repacked',
':jetty-servlets-repacked',
':jetty-util-repacked',
':jetty-continuation-repacked',
':jetty-io-repacked',
':jetty-jmx-repacked',
],
)

REPACK = [
'jetty-continuation',
'jetty-http',
Expand All @@ -52,13 +68,14 @@ for i in REPACK:
prebuilt_jar(
name = out,
maven_coords = 'org.seleniumhq.selenium:%s:9.2.13.v20150730' % out,
binary_jar = ':%s' % name
binary_jar = ':%s' % name,
deps = [ '//third_party/java/servlet:servlet-api', ],
)

export_file(
name = 'jarjar-rules',
src = 'jetty-repack-rules',
)
)

prebuilt_jar(
name = 'jetty-continuation',
Expand All @@ -76,7 +93,8 @@ prebuilt_jar(
binary_jar = 'jetty-http-9.2.13.v20150730.jar',
source_jar = 'jetty-http-9.2.13.v20150730-sources.jar',
deps = [
':jetty-util'
':jetty-util',
'//third_party/java/servlet:servlet-api',
],
)

Expand Down
1 change: 0 additions & 1 deletion third_party/java/servlet/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ prebuilt_jar(name = 'servlet-api',
'//java/server/src/com/thoughtworks/selenium/webdriven:rc-emulation-servlet',
'//java/server/test/com/thoughtworks/selenium/webdriven:webdriven',
'//java/server/src/org/openqa/selenium/remote/server:standalone-server-lib',
'//java/server/src/org/openqa/selenium/server:server',

# Everything under grid
'//java/server/src/org/openqa/grid/...',
Expand Down

0 comments on commit dd3f2e8

Please sign in to comment.