Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Move to the electron-vite build tool #3218

Merged
merged 9 commits into from
Jun 14, 2024
Merged

Conversation

CommandMC
Copy link
Collaborator

electron-vite is a slightly newer option for building Electron applications with Vite. Other than having some saner defaults and being generally more popular in the ecosystem, it also allows us to finally upgrade to Vite 4, which comes with noticeable speed improvements

I've done some testing of this on Linux and Windows, but due to architectural issues (the great CommonJS vs ESM split), literally any module we import might break with this. This is sadly unavoidable if we want to upgrade to a newer Vite version. If a module like this crops up in the future, we have to add it to electron.vite.config.ts's dependenciesToNotExternalize array
Due to this issue, more testing than normal will be necessary for this PR


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added pr:testing This PR is in testing, don't merge. pr:ready-for-review Feature-complete, ready for the grind! :P labels Nov 6, 2023
@CommandMC CommandMC requested a review from a team November 6, 2023 18:16
@CommandMC CommandMC self-assigned this Nov 6, 2023
@CommandMC CommandMC requested review from arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team November 6, 2023 18:16
@CommandMC CommandMC mentioned this pull request Nov 6, 2023
6 tasks
@CommandMC CommandMC mentioned this pull request Dec 16, 2023
12 tasks
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested some things like login, install, play, uninstall, install a wine, filtering, changing settings

all on linux seems to work fine

I didn't test building the app for release though

maybe we can merge this into main so we all use this more during development? not sure what others think

Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@CommandMC CommandMC merged commit 45358ad into main Jun 14, 2024
9 checks passed
@CommandMC CommandMC deleted the tech/electron-vite branch June 14, 2024 21:21
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants